Skip to content

Conversation

@danoli3
Copy link
Member

@danoli3 danoli3 commented Mar 2, 2025

I think this should allow platform iOS to function for PG

Aside from the other iOS project stuff:

@dimitre saw you just did storyboard changes yay! I can add to this for iOS fixes with cherry pick straight away if you wanted to merge this / that and continue with other fixes

@danoli3 danoli3 requested a review from dimitre March 2, 2025 01:55
@dimitre
Copy link
Member

dimitre commented Mar 2, 2025

It is best to see all other fixes first. I'm keeping everything in one PR so we don't have to rebase

@danoli3
Copy link
Member Author

danoli3 commented Mar 2, 2025

Also tested auto tag builds before any new PG updates, lets keep these ones for now: https://github.com/openframeworks/projectGenerator/releases/tag/v0.86.0

! just there is a macOS final target issue currently: Exit code 127 - command not found weird

@danoli3
Copy link
Member Author

danoli3 commented Mar 2, 2025

I'll leave the rest to you! I just saw in my mind it was that platform == osx thing in addons

@danoli3
Copy link
Member Author

danoli3 commented Mar 2, 2025

addon.prepareForWrite(); should get rid of these doubles its adding as well
cherry pick this onto ur PR
0306bda

@dimitre
Copy link
Member

dimitre commented Mar 2, 2025

what it is trying to fix? how to duplicate your particular issue?
Can you try with the PR ? I've seen something about duplication before .storyboard change but it is now ok

@danoli3
Copy link
Member Author

danoli3 commented Mar 2, 2025

oh it just forces a call on clean up dupes before write out for addon into project

@dimitre
Copy link
Member

dimitre commented Mar 2, 2025

ok I thought it was a fix by the name iOS targets fix

@danoli3 danoli3 merged commit 6747851 into openframeworks:master Mar 2, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants